v-bulle wrote:

> The one thing about this that strikes me as odd is that if you have an 
> SBValue that doesn't have a Synthetic Value, this will return the 
> non-synthetic value. The GetNonSyntheticValue didn't have this problem 
> because there's always a non-synthetic value, so provided the SBValue was 
> valid you could always hand that out.
> 
> Would it make more sense to make the ValueImpl that's going to represent the 
> synthetic value then check whether that really is synthetic, and return an 
> empty SBValue if it is not?

done

https://github.com/llvm/llvm-project/pull/95959
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to