labath wrote:

> This is a really nice cleanup! It actually aligns almost exactly with [our 
> in-progress version of 
> this](https://github.com/llvm/llvm-project/blob/caacb57a46f34bf663fa5ab2190b361ce29b255b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp).
> 
> LGTM
> 
> Agree with your point about `PrepareContextToReceiveMembers`. We can add 
> those as needed. In our version of this I had to only add it in 
> `ParseSubroutine`, as you've also effectively done.

Thanks. It's very nice when things fit together.

https://github.com/llvm/llvm-project/pull/96755
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to