slydiman wrote:
It seems this patch breaks the following tests on cross setups:
```
Failed Tests (6):
lldb-api :: commands/process/attach/TestProcessAttach.py
lldb-api :: commands/process/detach-resumes/TestDetachResumes.py
lldb-api :: functionalities/dyld-exec-linux/TestDyldExecLinux.py
lldb-api :: functionalities/dyld-launch-linux/TestDyldLaunchLinux.py
lldb-api :: functionalities/exec/TestExec.py
lldb-api ::
functionalities/thread/create_after_attach/TestCreateAfterAttach.py
```
Note the behavior is the same for Windows and Linux hosts with Linux AArch64
target.
Probably removing `RemoteAwarePlatform::ResolveExecutable` causes the issue.
For example here is the log for lldb-api ::
commands/process/attach/TestProcessAttach.py
```
Command Output (stdout):
--
Setting up remote platform 'remote-linux'
Connecting to remote platform 'remote-linux' at 'connect://test1:1234'...
Connected.
Setting remote platform working directory to '/home/ubuntu/lldb-tests'...
Skipping the following test categories: ['dsym', 'gmodules', 'debugserver',
'objc', 'lldb-dap']
--
Command Output (stderr):
--
PASS: LLDB (C:\\lldb-test-scripts\build-lldb\bin\clang.exe-aarch64) ::
test_attach_to_process_by_id
(TestProcessAttach.ProcessAttachTestCase.test_attach_to_process_by_id)
PASS: LLDB (C:\\lldb-test-scripts\build-lldb\bin\clang.exe-aarch64) ::
test_attach_to_process_by_id_autocontinue
(TestProcessAttach.ProcessAttachTestCase.test_attach_to_process_by_id_autocontinue)
FAIL: LLDB (C:\\lldb-test-scripts\build-lldb\bin\clang.exe-aarch64) ::
test_attach_to_process_by_id_correct_executable_offset
(TestProcessAttach.ProcessAttachTestCase.test_attach_to_process_by_id_correct_executable_offset)
PASS: LLDB (C:\lldb-test-scripts\build-lldb\bin\clang.exe-aarch64) ::
test_attach_to_process_by_name
(TestProcessAttach.ProcessAttachTestCase.test_attach_to_process_by_name)
PASS: LLDB (C:\lldb-test-scripts\build-lldb\bin\clang.exe-aarch64) ::
test_attach_to_process_from_different_dir_by_id
(TestProcessAttach.ProcessAttachTestCase.test_attach_to_process_from_different_dir_by_id)
======================================================================
FAIL: test_attach_to_process_by_id_correct_executable_offset
(TestProcessAttach.ProcessAttachTestCase.test_attach_to_process_by_id_correct_executable_offset)
Test that after attaching to a process the executable offset
----------------------------------------------------------------------
Traceback (most recent call last):
File
"C:\lldb-test-scripts\lldb\test\API\commands\process\attach\TestProcessAttach.py",
line 119, in test_attach_to_process_by_id_correct_executable_offset
lldbutil.run_break_set_by_file_and_line(
File "C:\\lldb-test-scripts\lldb\packages\Python\lldbsuite\test\lldbutil.py",
line 378, in run_break_set_by_file_and_line
check_breakpoint_result(
File "C:\\lldb-test-scripts\lldb\packages\Python\lldbsuite\test\lldbutil.py",
line 592, in check_breakpoint_result
test.assertTrue(
AssertionError: False is not true : Expecting 1 locations, got 0.
Ran 5 tests in 71.809s
FAILED (failures=1)
```
https://github.com/llvm/llvm-project/pull/96256
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
