labath wrote:

> Makes sense to me Do we make sure that the type lookup map is updated so we 
> don't re-parse when calling `ParseTypeFromDWARF` with either the declaration 
> or the definition DIE?

Good catch. I've been meaning to add that, but I forgot. Things should still 
work even without the DieToType update, as the type will be caught by the 
UniqueDWARFASTTypeMap, but this is definitely faster.

The way that the definition dies are currently handled is a bit clumsy now, but 
I didn't want to implement anything more elaborate as this should go away once 
we stop eagerly searching for the definition.

https://github.com/llvm/llvm-project/pull/96484
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to