jasonmolenda wrote:

This patch definitely needs review from Jim Ingham, who is out this week.  
@ZequanWu and @cmtice FYI. 

I tested this on arm64 macOS and on aarch64 Ubuntu - the important Process 
changes are were in ProcessGDBRemote, StopInfoMachException, and in 
ProcessWindows, I believe my testing will have exercised the first two set of 
changes (the largest and most complex).  I updated ProcessWindows as I believe 
it needs to be updated, but don't have a way of testing it short of merging the 
PR and seeing what happens to the windows CI bot.  

@AlexK0 if you have a setup to build and run the testsuite on windows, could 
you try it with this patch some time when you're able?  I can't see this being 
merged for at least another 5-6 days, there's no rush.  You can download the 
unidiff style diff of the patch from 
https://patch-diff.githubusercontent.com/raw/llvm/llvm-project/pull/96260.diff 

https://github.com/llvm/llvm-project/pull/96260
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to