https://github.com/jasonmolenda approved this pull request.
This looks good to me. The only thing I could suggest is that we check the specified fields/size are less than 64 bits when reading the enum field definitions, but that means I can specify fields above 32 bits and then associate that with a 32-bit cpsr register and it won't be detected. I feel like it's critical we be that careful with our input handling, but I thought I'd mention it to see what you think. https://github.com/llvm/llvm-project/pull/95768 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
