jasonmolenda wrote:
> > I hate to ruin a party, but I don't think this is a good use of > > `operator==`, precisely because it does not define an equivalence relation > > (it's not transitive). Might I suggest named function instead? > > `IsCompatible` ? > I'd be fine with `SupportFile::IsSameFile(SupportFile&)`, I think that would make it clear what is being evaluated in caller locations. But is it any different than operator==, which you'd expect to behave the same? https://github.com/llvm/llvm-project/pull/95606 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
