labath wrote: I should add that I'm pretty sure the index entries pointing to signature declaration DIEs were not the cause of crashes in @ZequanWu CLs, after creating the test case (what I think is the worst possible situation) and stepping through the code, I realized that these DIEs would get filtered out anyway on line DWARFIndex.cpp:126 (because `GetDWARFDeclContext` does not work on DW_AT_signature DIEs). Nonetheless, I think that this change makes sense because the fact that `GetDWARFDeclContext` is a bug that's probably preventing the correct lookup of types in some type unit scenarios. The check may very well become load-bearing if that function is fixed.
https://github.com/llvm/llvm-project/pull/94744 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
