[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)

[Zequan Wu via lldb-commits]

================
@@ -2306,6 +2345,11 @@ bool DWARFASTParserClang::CompleteTypeFromDWARF(const 
DWARFDIE &die,
 
   if (!die)
     return false;
+  ParsedDWARFTypeAttributes attrs(die);
----------------
ZequanWu wrote:

The parsing happens every time when constructing this object, which makes it a 
bit expensive, should we add a new field `DWARFAttributes m_attributes` in 
`DWARFBaseDIE`, so that we only parse it once? From a glance at calls to 
`DWARFBaseDIE::GetAttributes`, there are more than 10 calls to it. The 
attribute parsing is repetitive. 

https://github.com/llvm/llvm-project/pull/92328
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits