https://github.com/clayborg requested changes to this pull request.

So `ProcessInstanceInfo` is already very OS specific, so I can't object to 
adding more OS specific information to this structure. It would be nice to 
abstract OS specific things into a dictionary so allow OS specific things to be 
added with OS specific key/value pairs, but since it is already very unix 
centric these changes are ok. We have to be careful to not include OS specific 
header files like `<sys/resource.h>` as they won't be available on windows or 
other non linux OS versions. See inline comments for details.

https://github.com/llvm/llvm-project/pull/91544
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to