================
@@ -657,8 +657,11 @@ MinidumpFileBuilder::AddMemoryList(const lldb::ProcessSP
&process_sp,
auto data_up = std::make_unique<DataBufferHeap>(size, 0);
const size_t bytes_read =
process_sp->ReadMemory(addr, data_up->GetBytes(), size, error);
- if (bytes_read == 0)
+ if (error.Fail() || bytes_read == 0) {
----------------
jeffreytan81 wrote:
Instead of silently swallow the failure, we should emit the error message to
terminal/console so that users are aware of region skipping.
https://github.com/llvm/llvm-project/pull/88564
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
