kovdan01 wrote:

> As this plugin seems related to backtrace perhaps the test should at least 
> run `bt` and check for the first line of the output.

I had similar thoughts, but I'm not sure if placing the test in 
`lldb/test/Shell/Commands` as `command-backtrace-missing-x86.test` is a nice 
idea. The issue occurs during loading the core dump (or, when debugging an 
executable, when executing "run" command). So, running `bt` might be misleading 
- a one might think that we test an absence of nullptr dereference during `bt`, 
but we want to test that the core dump is at least loaded properly since with 
the issue present we don't even get to the point where we can run `bt`.

I would be glad to here other people's thoughts on that - I'm personally not 
sure which testing approach is less evil here.

https://github.com/llvm/llvm-project/pull/82603
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to