dwblaikie wrote: > > > I will aim to land this sometime tomorrow if there are no further > > > objections > > > > > > Per the documentation ( > > https://llvm.org/docs/CodeReview.html#code-review-workflow ), please don't > > do this. Once it's sent for review, please wait for approval (ping as > > needed, etc) before landing. > > Felipe already had Adrian's approval, and so far as I can see there were no > outstanding comments he hadn't addressed.
Ah, sorry - I scanned up and down but missed it (the UI's not quite as explicit as Phab is on whether a patch has been reviewed - but I could've looked in the top right and seen the check next to Adrian's name). Yeah, I don't expect multiple reviewer approval unless folks (either the submitter, or other reviewers) ask for it. If the it's approved with some optional comments and the discussion around those aspects has been resolved, fine by me to commit. https://github.com/llvm/llvm-project/pull/79932 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
