================
@@ -54,6 +55,34 @@ class PluginProperties : public Properties {
     return urls;
   }
 
+  llvm::Expected<llvm::StringRef> GetCachePath() {
----------------
JDevlieghere wrote:

Is it always safe to return a StringRef here? It looks fine at first sight, but 
this code also doesn't look particularly hot, so playing it safe and returning 
a `std::string` avoids having to reason about the string's lifetime.

https://github.com/llvm/llvm-project/pull/78605
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to