nmosier wrote: I went ahead and turned `TraceItemStorage` into a variant. I also deleted the memory usage / bytes from the tests. Also, I noticed some error messages were different for some tests — I'm guessing they may have changed in newer versions of libipt.
Right now, only 1 test fails: ``` ====================================================================== FAIL: testStartPerCpuSession (TestTraceStartStopMultipleThreads.TestTraceStartStopMultipleThreads) ---------------------------------------------------------------------- Traceback (most recent call last): File "/llvm/lldb/packages/Python/lldbsuite/test/decorators.py", line 162, in wrapper return func(*args, **kwargs) File "/llvm/lldb/packages/Python/lldbsuite/test/tools/intelpt/intelpt_testcase.py", line 14, in wrapper func(*args, **kwargs) File "/llvm/lldb/test/API/commands/trace/multiple-threads/TestTraceStartStopMultipleThreads.py", line 260, in testStartPerCpuSession self.expect("thread trace dump instructions") File "/llvm/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 2353, in expect self.runCmd( File "/llvm/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 2031, in runCmd self.assertTrue(self.res.Succeeded(), msg if (msg) else CMD_MSG(cmd)) AssertionError: False is not True : Command 'thread trace dump instructions Error output: error: Malformed perf context switch trace for cpu 14 at offset 64. A context switch record doesn't happen after the previous record. Previous TSC= 2215501248, current TSC = 22155012 48. ' did not return successfully Config=x86_64-/llvm-build/bin/clang ``` https://github.com/llvm/llvm-project/pull/77252 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits