https://github.com/bulbazord approved this pull request.

LGTM. It may be a good idea to move these APIs over to use std::optional 
instead of taking a default value so we can use 'value_or' instead of having to 
write logic to handle the default value through a parameter.

https://github.com/llvm/llvm-project/pull/72902
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to