Author: Alex Langford Date: 2023-11-09T13:34:59-08:00 New Revision: fe98cce6a91c7240a541b213d43d1132c684fd9c
URL: https://github.com/llvm/llvm-project/commit/fe98cce6a91c7240a541b213d43d1132c684fd9c DIFF: https://github.com/llvm/llvm-project/commit/fe98cce6a91c7240a541b213d43d1132c684fd9c.diff LOG: [lldb] Change Breakpoint::AddName return value (#71236) The return value is completely unused. Let's just return nothing. Added: Modified: lldb/include/lldb/Breakpoint/Breakpoint.h lldb/source/Breakpoint/Breakpoint.cpp Removed: ################################################################################ diff --git a/lldb/include/lldb/Breakpoint/Breakpoint.h b/lldb/include/lldb/Breakpoint/Breakpoint.h index f2380157f111dd6..3a8b29aee544c63 100644 --- a/lldb/include/lldb/Breakpoint/Breakpoint.h +++ b/lldb/include/lldb/Breakpoint/Breakpoint.h @@ -523,9 +523,8 @@ class Breakpoint : public std::enable_shared_from_this<Breakpoint>, lldb::SearchFilterSP GetSearchFilter() { return m_filter_sp; } -private: // The target needs to manage adding & removing names. It will do the - // checking for name validity as well. - bool AddName(llvm::StringRef new_name); +private: + void AddName(llvm::StringRef new_name); void RemoveName(const char *name_to_remove) { if (name_to_remove) diff --git a/lldb/source/Breakpoint/Breakpoint.cpp b/lldb/source/Breakpoint/Breakpoint.cpp index ff4f195ea30909e..a94498a23a0fb27 100644 --- a/lldb/source/Breakpoint/Breakpoint.cpp +++ b/lldb/source/Breakpoint/Breakpoint.cpp @@ -841,9 +841,8 @@ bool Breakpoint::HasResolvedLocations() const { size_t Breakpoint::GetNumLocations() const { return m_locations.GetSize(); } -bool Breakpoint::AddName(llvm::StringRef new_name) { +void Breakpoint::AddName(llvm::StringRef new_name) { m_name_list.insert(new_name.str()); - return true; } void Breakpoint::GetDescription(Stream *s, lldb::DescriptionLevel level, _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
