Author: Michael Buch Date: 2023-10-06T16:05:40+01:00 New Revision: d579a1a24adc26794d9a720cea52f7bb8f37c683
URL: https://github.com/llvm/llvm-project/commit/d579a1a24adc26794d9a720cea52f7bb8f37c683 DIFF: https://github.com/llvm/llvm-project/commit/d579a1a24adc26794d9a720cea52f7bb8f37c683.diff LOG: [lldb[test] TestCppUnionStaticMembers.py: XFAIL assertions on windows (#68408) Split out the assertions that fail on Windows in preparation to XFAILing them. Drive-by change: * Add a missing `self.build()` call in `test_union_in_anon_namespace` * Fix formatting * Add expectedFailureWindows decorator Added: Modified: lldb/packages/Python/lldbsuite/test/decorators.py lldb/test/API/lang/cpp/union-static-data-members/TestCppUnionStaticMembers.py Removed: ################################################################################ diff --git a/lldb/packages/Python/lldbsuite/test/decorators.py b/lldb/packages/Python/lldbsuite/test/decorators.py index 6194862f8fe60f9..b8fea1e02e864de 100644 --- a/lldb/packages/Python/lldbsuite/test/decorators.py +++ b/lldb/packages/Python/lldbsuite/test/decorators.py @@ -511,6 +511,10 @@ def expectedFailureNetBSD(bugnumber=None): return expectedFailureOS(["netbsd"], bugnumber) +def expectedFailureWindows(bugnumber=None): + return expectedFailureOS(["windows"], bugnumber) + + # TODO: This decorator does not do anything. Remove it. def expectedFlakey(expected_fn, bugnumber=None): def expectedFailure_impl(func): diff --git a/lldb/test/API/lang/cpp/union-static-data-members/TestCppUnionStaticMembers.py b/lldb/test/API/lang/cpp/union-static-data-members/TestCppUnionStaticMembers.py index 47166636b12647c..1988e997499b222 100644 --- a/lldb/test/API/lang/cpp/union-static-data-members/TestCppUnionStaticMembers.py +++ b/lldb/test/API/lang/cpp/union-static-data-members/TestCppUnionStaticMembers.py @@ -8,14 +8,14 @@ import lldbsuite.test.lldbutil as lldbutil class CppUnionStaticMembersTestCase(TestBase): - def test(self): + def test_print_union(self): """Tests that frame variable and expr work - for union static data members""" + for union with static data members""" self.build() (target, process, main_thread, _) = lldbutil.run_to_source_breakpoint( self, "return 0", lldb.SBFileSpec("main.cpp") - ) + ) self.expect("frame variable foo", substrs=["val = 42"]) self.expect("frame variable bar", substrs=["val = 137"]) @@ -27,6 +27,16 @@ def test(self): name="val", value="137" )]) + @expectedFailureWindows + def test_expr_union_static_members(self): + """Tests that frame variable and expr work + for union static data members""" + self.build() + + (target, process, main_thread, _) = lldbutil.run_to_source_breakpoint( + self, "return 0", lldb.SBFileSpec("main.cpp") + ) + self.expect_expr("Foo::sVal1", result_type="const int", result_value="-42") self.expect_expr("Foo::sVal2", result_type="Foo", result_children=[ValueCheck( name="val", value="42" @@ -37,6 +47,12 @@ def test_union_in_anon_namespace(self): """Tests that frame variable and expr work for union static data members in anonymous namespaces""" + self.build() + + (target, process, main_thread, _) = lldbutil.run_to_source_breakpoint( + self, "return 0", lldb.SBFileSpec("main.cpp") + ) + self.expect_expr("Bar::sVal1", result_type="const int", result_value="-137") self.expect_expr("Bar::sVal2", result_type="Bar", result_children=[ValueCheck( name="val", value="137" _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
