jimingham wrote: That watchpoints can be inaccurate is probably news to a lot of debugger users, and knowing that might save somebody a fruitless hour wondering "how that variable could be being modified here..." But I don't think most folks are likely to see the API doc string. Might be more useful to mention this in the "watch set" help.
Jikm > On Sep 18, 2023, at 6:38 PM, Greg Clayton ***@***.***> wrote: > > > @clayborg approved this pull request. > > Thanks for the changes! Looks great > > In lldb/bindings/interface/SBWatchpointOptionsDocstrings.i > <https://github.com/llvm/llvm-project/pull/66308#discussion_r1329453193>: > > > @@ -6,11 +6,7 @@ > ) lldb::SBWatchpointOptions::SetWatchpointTypeRead; > %feature("docstring", "Gets whether the watchpoint should stop on read > accesses." > ) lldb::SBWatchpointOptions::GetWatchpointTypeRead; > -%feature("docstring", "Sets whether the watchpoint should stop on write > accesses." > +%feature("docstring", "Sets whether the watchpoint should stop on write > accesses. eWatchpointWriteTypeOnModify is the most commonly useful mode, > where lldb will stop when the watched value has changed. > eWatchpointWriteTypeAlways will stop on any write to the watched region, and > on some targets there can false watchpoint stops where memory near the > watched region was written, and lldb cannot detect that it is a spurious > stop." > Do we need to state "and on some targets there can false watchpoint stops > where memory near the watched region was written, and lldb cannot detect that > it is a spurious stop."? Can we remove that? Seems like information that most > users wouldn't need to know? > > — > Reply to this email directly, view it on GitHub > <https://github.com/llvm/llvm-project/pull/66308#pullrequestreview-1632250909>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ADUPVWYQDHG3WAIHK77KF2DX3DZRNANCNFSM6AAAAAA4XKAUOQ>. > You are receiving this because your review was requested. > https://github.com/llvm/llvm-project/pull/66308 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
