JDevlieghere added a comment.

Overall this looks good, but instead of consuming all the errors, let's log 
them with `LLDB_LOG_ERROR`. Note that the API is a bit tricky and still 
requires you to provide a format string:

  LLDB_LOG_ERROR(GetLog(LLDBLog::Object), something.takeError(), "context 
before printing the actual error: {0}");


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159408/new/

https://reviews.llvm.org/D159408

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to