compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land.
LGTM with @kastiglione's comments addressed. ================ Comment at: lldb/source/Core/Section.cpp:153 + case eSectionTypeSwiftModules: + return "swift-modules"; } ---------------- kastiglione wrote: > I wonder if this should be "swiftmodules". I have never seen it spelled with > a hyphen. Is it actually more than one module? If not, `swift-module` would make sense given the DWARF cases - it is a "Swift Module" converted to lower kebab case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159142/new/ https://reviews.llvm.org/D159142 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
