Author: Jonas Devlieghere Date: 2023-08-07T15:50:06-07:00 New Revision: 300c5aaa0a2ae3b5bb7d14d4f11d93e4ea2666c1
URL: https://github.com/llvm/llvm-project/commit/300c5aaa0a2ae3b5bb7d14d4f11d93e4ea2666c1 DIFF: https://github.com/llvm/llvm-project/commit/300c5aaa0a2ae3b5bb7d14d4f11d93e4ea2666c1.diff LOG: [lldb] Remove unused Socket::PreDisconnect (NFC) Added: Modified: lldb/include/lldb/Host/Socket.h lldb/source/Host/common/Socket.cpp lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp Removed: ################################################################################ diff --git a/lldb/include/lldb/Host/Socket.h b/lldb/include/lldb/Host/Socket.h index 01f790ee11fb8c..4dad88e78faa11 100644 --- a/lldb/include/lldb/Host/Socket.h +++ b/lldb/include/lldb/Host/Socket.h @@ -93,7 +93,6 @@ class Socket : public IOObject { Status Read(void *buf, size_t &num_bytes) override; Status Write(const void *buf, size_t &num_bytes) override; - virtual Status PreDisconnect(); Status Close() override; bool IsValid() const override { return m_socket != kInvalidSocketValue; } diff --git a/lldb/source/Host/common/Socket.cpp b/lldb/source/Host/common/Socket.cpp index 8ccb27fdd7f452..bd0c127a08956e 100644 --- a/lldb/source/Host/common/Socket.cpp +++ b/lldb/source/Host/common/Socket.cpp @@ -269,11 +269,6 @@ Status Socket::Write(const void *buf, size_t &num_bytes) { return error; } -Status Socket::PreDisconnect() { - Status error; - return error; -} - Status Socket::Close() { Status error; if (!IsValid() || !m_should_close_fd) diff --git a/lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp b/lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp index 825da09d760224..6a367a3307e543 100644 --- a/lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp +++ b/lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp @@ -202,9 +202,6 @@ ConnectionStatus ConnectionFileDescriptor::Disconnect(Status *error_ptr) { return eConnectionStatusSuccess; } - if (m_io_sp->GetFdType() == IOObject::eFDTypeSocket) - static_cast<Socket &>(*m_io_sp).PreDisconnect(); - // Try to get the ConnectionFileDescriptor's mutex. If we fail, that is // quite likely because somebody is doing a blocking read on our file // descriptor. If that's the case, then send the "q" char to the command _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
