aprantl added a comment.

> If it's straightforward, I think would be nice to have a unit test with two 
> threads modifying the same OptionValue. That way a TSan run would catch this 
> issue. If that's more work than expected then this is fine as is.

We might just want to set up a bot that runs the entire test suite under TSan, 
assuming that we can get it clean?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157041/new/

https://reviews.llvm.org/D157041

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to