JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed.
I'm okay with the ABI break given that this (1) hasn't made it into a release yet, (2) it is under active development by Ismail himself and (3) has existing adopters beyond the ones motivating the original and current change. However, now that it's more than a typedef, we should rename ScriptObject to `SBScriptObject`, move it to its own file and hide its implementation with PIMPL. There is no precedent for having small structs in lldb-types and I don't see why we would want lock ourselves into the current implementation. If anything this patch itself serves as an example that we want the ability to change this class without breaking the ABI (again). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155161/new/ https://reviews.llvm.org/D155161 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
