This revision was automatically updated to reflect the committed changes. Closed by commit rGfdf36c3d4b46: [lldb][AArch64] Fix flakiness in TestSVEThreadedDynamic (authored by DavidSpickett).
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154705/new/ https://reviews.llvm.org/D154705 Files: lldb/test/API/commands/register/register/aarch64_sve_registers/rw_access_dynamic_resize/TestSVEThreadedDynamic.py Index: lldb/test/API/commands/register/register/aarch64_sve_registers/rw_access_dynamic_resize/TestSVEThreadedDynamic.py =================================================================== --- lldb/test/API/commands/register/register/aarch64_sve_registers/rw_access_dynamic_resize/TestSVEThreadedDynamic.py +++ lldb/test/API/commands/register/register/aarch64_sve_registers/rw_access_dynamic_resize/TestSVEThreadedDynamic.py @@ -125,8 +125,6 @@ process = self.dbg.GetSelectedTarget().GetProcess() - thread1 = process.GetThreadAtIndex(0) - self.expect( "thread info 1", STOPPED_DUE_TO_BREAKPOINT, @@ -140,6 +138,10 @@ self.runCmd("process continue", RUN_SUCCEEDED) + # If we start the checks too quickly, thread 3 may not have started. + while (process.GetNumThreads() < 3): + pass + for idx in range(1, process.GetNumThreads()): thread = process.GetThreadAtIndex(idx) if thread.GetStopReason() != lldb.eStopReasonBreakpoint:
Index: lldb/test/API/commands/register/register/aarch64_sve_registers/rw_access_dynamic_resize/TestSVEThreadedDynamic.py =================================================================== --- lldb/test/API/commands/register/register/aarch64_sve_registers/rw_access_dynamic_resize/TestSVEThreadedDynamic.py +++ lldb/test/API/commands/register/register/aarch64_sve_registers/rw_access_dynamic_resize/TestSVEThreadedDynamic.py @@ -125,8 +125,6 @@ process = self.dbg.GetSelectedTarget().GetProcess() - thread1 = process.GetThreadAtIndex(0) - self.expect( "thread info 1", STOPPED_DUE_TO_BREAKPOINT, @@ -140,6 +138,10 @@ self.runCmd("process continue", RUN_SUCCEEDED) + # If we start the checks too quickly, thread 3 may not have started. + while (process.GetNumThreads() < 3): + pass + for idx in range(1, process.GetNumThreads()): thread = process.GetThreadAtIndex(idx) if thread.GetStopReason() != lldb.eStopReasonBreakpoint:
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits