fdeazeve added inline comments.
================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:232 + + llvm::StringRef expected_name = context[0].name; + ---------------- JDevlieghere wrote: > JDevlieghere wrote: > > I assume we always have at least one entry (or that's the assumption here). > > I was going to suggest adding an `assert` here but then I looked at the > > `lldb_private::DWARFDeclContext::operator[]` implementation and I think the > > assert should probably go there. That's orthogonal to this patch though. > https://reviews.llvm.org/D153921 > I assume we always have at least one entry (or that's the assumption here). I believe so. We had this assumption previously, so I didn't want to change that in this already tricky patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153867/new/ https://reviews.llvm.org/D153867 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
