JDevlieghere requested changes to this revision.
JDevlieghere added inline comments.
This revision now requires changes to proceed.
================
Comment at: lldb/include/lldb/Interpreter/OptionGroupPlatform.h:52
- void SetSDKRootDirectory(ConstString sdk_root_directory) {
- m_sdk_sysroot = sdk_root_directory;
+ void SetSDKRootDirectory(llvm::StringRef sdk_root_directory) {
+ m_sdk_sysroot = sdk_root_directory.str();
----------------
This should take a std::string by value and move it.
================
Comment at: lldb/include/lldb/Interpreter/OptionGroupPlatform.h:58
- void SetSDKBuild(ConstString sdk_build) { m_sdk_build = sdk_build; }
+ void SetSDKBuild(llvm::StringRef sdk_build) { m_sdk_build = sdk_build.str();
}
----------------
Same here
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152331/new/
https://reviews.llvm.org/D152331
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
