mib added inline comments.
================
Comment at: lldb/scripts/generate-project.py:23
+ with open(header_path, "w") as f:
+ file_contents = (
+ f"#ifndef _OBJ{index}_H\n"
----------------
nit: Is it necessary to put it in a variable or could you have a multiline
string in the `write` call ?
================
Comment at: lldb/scripts/generate-project.py:183-190
+ f.write("OBJDIR=objs\n")
+ f.write("SDK=$(shell xcrun --show-sdk-path)\n")
+ f.write("SWIFT_FE=swift -frontend\n")
+ f.write("SWIFT_FEFLAGS=-g -Onone -serialize-debugging-options \\\n")
+ f.write(" -sdk $(SDK) -enable-anonymous-context-mangled-names\n")
+ f.write("SWIFTC=swiftc\n")
+ f.write("\n")
----------------
What about here ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152569/new/
https://reviews.llvm.org/D152569
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
