bulbazord added a comment. In D152582#4410002 <https://reviews.llvm.org/D152582#4410002>, @mib wrote:
> Don't you need to update the callers as well ? Otherwise LGTM. ConstString can be implicitly converted to StringRef which is what's happening here. There are only 2 call sites, both pass in a ConstString. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152582/new/ https://reviews.llvm.org/D152582 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits