bulbazord added inline comments.

================
Comment at: lldb/test/API/functionalities/completion/TestCompletion.py:439-450
+    def test_completion_target_create_from_root_dir(self):
+        """Tests source file completion by completing ."""
+        root_dir = os.path.abspath(os.sep)
+        self.completions_contain(
+            "target create /",
+            list(
+                filter(
----------------
I'm curious to know if this will work for windows? I don't know how lldb treats 
`/` as a path when on a windows host.

`root_dir` should be `os.path.abspath('\\')` on windows, which might give you 
`C:\` or whatever the current drive is, so that path might possibly give you 
something? Idk, you might have to fiddle with the test to get it to work 
correctly or disable it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152013/new/

https://reviews.llvm.org/D152013

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to