mib marked 3 inline comments as done.
mib added inline comments.
================
Comment at: lldb/source/Commands/CommandObjectTarget.cpp:546-551
+ if (!name.empty()) {
+ if (name == target_idx_arg) {
+ target_idx = i;
+ break;
+ }
+ }
----------------
bulbazord wrote:
> nit:
>
> Also, do we need the empty check? Or is it possible that `target_idx_arg`
> could be an empty string?
We need to keep the empty check otherwise `target select ""` would select the
first non-labeled target which would be wrong.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151859/new/
https://reviews.llvm.org/D151859
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
