jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.

LGTM

The help string for the setting seems clear.  There's also some logic to handle 
the setting vrs. the values we find from the stub which you describe in the 
comment to the review, but it would be nice to see that in a comment in the 
code somewhere to help out future generations.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151292/new/

https://reviews.llvm.org/D151292

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to