Author: Alex Langford Date: 2023-05-23T15:14:47-07:00 New Revision: 973f1fe7a8591c7af148e573491ab68cc15b6ecf
URL: https://github.com/llvm/llvm-project/commit/973f1fe7a8591c7af148e573491ab68cc15b6ecf DIFF: https://github.com/llvm/llvm-project/commit/973f1fe7a8591c7af148e573491ab68cc15b6ecf.diff LOG: [lldb][NFCI] Remove unused member from ObjectFileMachO >From what I can see, `m_mach_segments` is completely unused. Let's remove it. Differential Revision: https://reviews.llvm.org/D151236 Added: Modified: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h Removed: ################################################################################ diff --git a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp index 0c33ece464bb9..d78ed63b0e42d 100644 --- a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp +++ b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp @@ -940,9 +940,9 @@ ObjectFileMachO::ObjectFileMachO(const lldb::ModuleSP &module_sp, lldb::offset_t file_offset, lldb::offset_t length) : ObjectFile(module_sp, file, file_offset, length, data_sp, data_offset), - m_mach_segments(), m_mach_sections(), m_entry_point_address(), - m_thread_context_offsets(), m_thread_context_offsets_valid(false), - m_reexported_dylibs(), m_allow_assembly_emulation_unwind_plans(true) { + m_mach_sections(), m_entry_point_address(), m_thread_context_offsets(), + m_thread_context_offsets_valid(false), m_reexported_dylibs(), + m_allow_assembly_emulation_unwind_plans(true) { ::memset(&m_header, 0, sizeof(m_header)); ::memset(&m_dysymtab, 0, sizeof(m_dysymtab)); } @@ -952,9 +952,9 @@ ObjectFileMachO::ObjectFileMachO(const lldb::ModuleSP &module_sp, const lldb::ProcessSP &process_sp, lldb::addr_t header_addr) : ObjectFile(module_sp, process_sp, header_addr, header_data_sp), - m_mach_segments(), m_mach_sections(), m_entry_point_address(), - m_thread_context_offsets(), m_thread_context_offsets_valid(false), - m_reexported_dylibs(), m_allow_assembly_emulation_unwind_plans(true) { + m_mach_sections(), m_entry_point_address(), m_thread_context_offsets(), + m_thread_context_offsets_valid(false), m_reexported_dylibs(), + m_allow_assembly_emulation_unwind_plans(true) { ::memset(&m_header, 0, sizeof(m_header)); ::memset(&m_dysymtab, 0, sizeof(m_dysymtab)); } @@ -1622,10 +1622,6 @@ void ObjectFileMachO::ProcessSegmentCommand( const bool segment_is_encrypted = (load_cmd.flags & SG_PROTECTED_VERSION_1) != 0; - // Keep a list of mach segments around in case we need to get at data that - // isn't stored in the abstracted Sections. - m_mach_segments.push_back(load_cmd); - // Use a segment ID of the segment index shifted left by 8 so they never // conflict with any of the sections. SectionSP segment_sp; diff --git a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h index bea77c3d4eb95..7099a4fbadf40 100644 --- a/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h +++ b/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h @@ -269,7 +269,6 @@ class ObjectFileMachO : public lldb_private::ObjectFile { static lldb_private::ConstString GetSectionNameEHFrame(); llvm::MachO::dysymtab_command m_dysymtab; - std::vector<llvm::MachO::segment_command_64> m_mach_segments; std::vector<llvm::MachO::section_64> m_mach_sections; std::optional<llvm::VersionTuple> m_min_os_version; std::optional<llvm::VersionTuple> m_sdk_versions; _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
