bulbazord marked an inline comment as done. bulbazord added inline comments.
================ Comment at: lldb/source/API/SBFunction.cpp:181 + + return variable_sp->GetName().GetCString(); } ---------------- mib wrote: > nit: This threw me off, I thought you forgot to create a `ConsString` but it > seems that `ConstString` has both a `AsCString` and a `GetCString` method. It > would be good to stay consistent. Yeah, maybe we should try to remove either `GetCString` or `AsCString` and be uniform everywhere. Let's plan on doing that later though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150804/new/ https://reviews.llvm.org/D150804 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
