jgorbe created this revision. jgorbe added reviewers: Michael137, dblaikie, aprantl. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision.
The functionality added by https://reviews.llvm.org/D145803 is gated by lldb tuning, so we need to build the test programs with `-glldb` to make these tests print the expected preferred name. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D148582 Files: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/Makefile lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unique_ptr/Makefile Index: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unique_ptr/Makefile =================================================================== --- lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unique_ptr/Makefile +++ lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unique_ptr/Makefile @@ -2,5 +2,7 @@ USE_LIBCPP := 1 -CXXFLAGS_EXTRAS := -std=c++14 +# We need debug info tuning for lldb in order to emit the preferred name for +# std::string. See https://reviews.llvm.org/D145803. +CXXFLAGS_EXTRAS := -std=c++14 -glldb include Makefile.rules Index: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/Makefile =================================================================== --- lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/Makefile +++ lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/Makefile @@ -2,5 +2,7 @@ USE_LIBCPP := 1 -CXXFLAGS_EXTRAS := -std=c++14 +# We need debug info tuning for lldb in order to emit the preferred name for +# std::string. See https://reviews.llvm.org/D145803. +CXXFLAGS_EXTRAS := -std=c++14 -glldb include Makefile.rules
Index: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unique_ptr/Makefile =================================================================== --- lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unique_ptr/Makefile +++ lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/unique_ptr/Makefile @@ -2,5 +2,7 @@ USE_LIBCPP := 1 -CXXFLAGS_EXTRAS := -std=c++14 +# We need debug info tuning for lldb in order to emit the preferred name for +# std::string. See https://reviews.llvm.org/D145803. +CXXFLAGS_EXTRAS := -std=c++14 -glldb include Makefile.rules Index: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/Makefile =================================================================== --- lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/Makefile +++ lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/Makefile @@ -2,5 +2,7 @@ USE_LIBCPP := 1 -CXXFLAGS_EXTRAS := -std=c++14 +# We need debug info tuning for lldb in order to emit the preferred name for +# std::string. See https://reviews.llvm.org/D145803. +CXXFLAGS_EXTRAS := -std=c++14 -glldb include Makefile.rules
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
