DavidSpickett added a comment. Thanks for the test changes, looks good.
There is some documentation that lists what targets we support, MSP430 should be added there. `lldb/docs/index.rst` is one of those. Otherwise, can anyone else think of major debug features that should be (at least) smoke tested? (of course you could do this in follow up patches if it needs more work) ================ Comment at: lldb/test/API/functionalities/gdb_remote_client/TestMSP430MSPDebug.py:103 + self.assertEqual(reg.GetValueAsUnsigned(), + reg_val_dict[reg.GetName()]) + ---------------- Write some registers too? Again, not likely to find anything, just ensures we have the right offsets and don't take the wrong 16 bits out of the value. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D146965 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
