jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land.
LGTM. We can detect this This is one of those cases where I'd like to mark SBTarget::SetModuleLoadAddress as deprecated. I like that you detect this situation in SBTarget::SetLoadAddress - we could cast to unsigned and do the right thing, or would the compiler get unhappy? - but when I've seen these kinds of mistakes in the past, python detects a too-large unsigned value being passed to a signed argument and throws an error before we even get to the SetModuleLoadAddress, so it doesn't help much I expect for Python SB API users. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147482/new/ https://reviews.llvm.org/D147482 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
