jwnhy added a comment. In D147606#4245804 <https://reviews.llvm.org/D147606#4245804>, @DavidSpickett wrote:
> I'm not familiar with this code, but the issue as explained I think I > understand. > > It seems like you're checking for empty ranges in two places, what does each > one do? > > Is there anything else these ranges indicate or do we think it is simply a > missed optimisation in the debug info producer? If they do sometimes mean > something, then perhaps improving the searching of the ranges is preferable > to discarding the empty ones. > (though if all tests pass with this patch then these empty ranges can't be > that important to us can they) Thanks for the comments, I didn't improve the search because that searching logic seems being used everywhere and not just restricted to filter through these "address ranges", I am a bit afraid of changing that also changes something subtle. though it seems not making much sense to returning a "empty range" as searching results. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147606/new/ https://reviews.llvm.org/D147606 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
