compnerd added inline comments.
================
Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:869-873
LLDB_LOG(log,
"ObjectFilePECOFF::AppendFromExportTable - failed to get export
"
"table entry name: {0}",
llvm::fmt_consume(std::move(err)));
+ llvm::consumeError(std::move(err));
----------------
bulbazord wrote:
> If logging is enabled, we are moving from the same object twice, no?
>
> I think we should rethink the LLDB_LOG macro when it comes to errors.... :/
Yeah ... I was worried about that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147669/new/
https://reviews.llvm.org/D147669
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
