Michael137 added inline comments.

================
Comment at: lldb/source/Target/Language.cpp:272
+  case eLanguageTypeC_plus_plus_17:
+  case eLanguageTypeC_plus_plus_20:
   case eLanguageTypeObjC_plus_plus:
----------------
aprantl wrote:
> Can you check if we already have a similar function in Dwarf.h in LLVM?
we do in fact :)

`dwarf::isCplusPlus`

The only remaining quirk is that we one of the language constants 
(`DW_LANG_Mips_Assembler`) doesn't match the DWARF constants. Which isn't 
really a problem for this particular function


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143062/new/

https://reviews.llvm.org/D143062

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to