bulbazord added inline comments.
================
Comment at: lldb/source/Commands/CommandObjectRegister.cpp:229
+ if (!DumpRegister(m_exe_ctx, strm, reg_ctx, reg_info,
+ /*print_flags=*/true, type_system))
strm.Printf("%-12s = error: unavailable\n", reg_info->name);
----------------
DavidSpickett wrote:
> aprantl wrote:
> > Do we need to pass this in explicitly or could the implementation do the
> > `Target::GetScratchTypeSystemForLanguage::GetForTarget(m_exe_ctx.GetTargetRef())`?
> > That would avoid introducing a plugin dependence at least in this file?
> Yes I could do that. Though I think even `Core/DumpRegisterValue.cpp` using
> it isn't good.
>
> Is that right @bulbazord ?
Yes, avoiding plugin dependencies in non-plugins would be ideal.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145580/new/
https://reviews.llvm.org/D145580
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
