kastiglione created this revision.
kastiglione added a reviewer: aprantl.
Herald added a project: All.
kastiglione requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Change lldb-vscode to use the `expression` command for generating completions, 
instead
of the `p` alias.

Aliases are user overrideable, and even deletable, but the `expression` command 
is
unchangeable.

See D141539 <https://reviews.llvm.org/D141539> where a similar replacement was 
done to tests.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D145437

Files:
  lldb/tools/lldb-vscode/lldb-vscode.cpp


Index: lldb/tools/lldb-vscode/lldb-vscode.cpp
===================================================================
--- lldb/tools/lldb-vscode/lldb-vscode.cpp
+++ lldb/tools/lldb-vscode/lldb-vscode.cpp
@@ -1065,7 +1065,7 @@
     text = text.substr(1);
     actual_column--;
   } else {
-    text = "p " + text;
+    text = "expression -- " + text;
     actual_column += 2;
   }
   lldb::SBStringList matches;


Index: lldb/tools/lldb-vscode/lldb-vscode.cpp
===================================================================
--- lldb/tools/lldb-vscode/lldb-vscode.cpp
+++ lldb/tools/lldb-vscode/lldb-vscode.cpp
@@ -1065,7 +1065,7 @@
     text = text.substr(1);
     actual_column--;
   } else {
-    text = "p " + text;
+    text = "expression -- " + text;
     actual_column += 2;
   }
   lldb::SBStringList matches;
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to