mib marked an inline comment as done.
mib added inline comments.

================
Comment at: lldb/source/Utility/ProcessInfo.cpp:11
 
+#include "lldb/Interpreter/ScriptedMetadata.h"
 #include "lldb/Utility/ArchSpec.h"
----------------
labath wrote:
> This is a layering violation. Can we restructure this so that it this does 
> not depend on code outside the Utility library? Maybe the ScriptedMetadata 
> thingy could be moved into the Utility library?
@labath Thanks for pointing this out! I fixed it in D145414


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143104/new/

https://reviews.llvm.org/D143104

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to