aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

I think this is fine. It's concise, adds useful plugin functionality and we're 
already hardcoding all sorts of special knowledge about libc++.



================
Comment at: lldb/include/lldb/Target/LanguageRuntime.h:154
 
+  virtual bool ShouldHideVariable(llvm::StringRef name) const { return false; }
+
----------------
Can you add a doxygen comment about the effects here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145245/new/

https://reviews.llvm.org/D145245

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to