aprantl added a comment.
Generally LGTM, with one possible improvement inline!
================
Comment at: lldb/test/API/api/multiple-debuggers/TestMultipleDebuggers.py:20
+ # We need this in order to run under ASAN, in case only LLDB is
ASANified.
+ 'ASAN_OPTIONS':'detect_container_overflow=0'}
----------------
IIUC, the python process executing this python code should already have this
flag passed in via lit, so if it's possible to say something like
`'ASAN_OPTIONS':getEnv('ASAN_OPTIONS'` then that would be the cleanest
implementation.
================
Comment at: lldb/test/Shell/Host/TestCustomShell.test:10
# RUN: SHELL=bogus not %lldb %t.out -b -o 'process launch -X 1 --' 2>&1 |
FileCheck %s --check-prefix ERROR
-# RUN: env -i %lldb %t.out -b -o 'process launch -X 1 --' 2>&1 | FileCheck %s
+# RUN: env -i ASAN_OPTIONS='detect_container_overflow=0' %lldb %t.out -b -o
'process launch -X 1 --' 2>&1 | FileCheck %s
----------------
This is as good as we can do.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143772/new/
https://reviews.llvm.org/D143772
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
