JDevlieghere created this revision.
JDevlieghere added a reviewer: bulbazord.
Herald added a project: All.
JDevlieghere requested review of this revision.
We no longer need to remove a directory downstream and also contrary to my
previous observations, remove_directory isn't sufficient to remove a regular
file.
https://reviews.llvm.org/D143024
Files:
lldb/cmake/modules/AddLLDB.cmake
Index: lldb/cmake/modules/AddLLDB.cmake
===================================================================
--- lldb/cmake/modules/AddLLDB.cmake
+++ lldb/cmake/modules/AddLLDB.cmake
@@ -246,10 +246,8 @@
# Create a custom target to remove the copy again from LLDB.framework in the
# build tree.
- # Intentionally use remove_directory because the target can be a either a
- # file or directory and using remove_directory is harmless for files.
add_custom_target(${name}-cleanup
- COMMAND ${CMAKE_COMMAND} -E remove_directory ${copy_dest}
+ COMMAND ${CMAKE_COMMAND} -E remove ${copy_dest}
COMMENT "Removing ${name} from LLDB.framework")
add_dependencies(lldb-framework-cleanup
${name}-cleanup)
Index: lldb/cmake/modules/AddLLDB.cmake
===================================================================
--- lldb/cmake/modules/AddLLDB.cmake
+++ lldb/cmake/modules/AddLLDB.cmake
@@ -246,10 +246,8 @@
# Create a custom target to remove the copy again from LLDB.framework in the
# build tree.
- # Intentionally use remove_directory because the target can be a either a
- # file or directory and using remove_directory is harmless for files.
add_custom_target(${name}-cleanup
- COMMAND ${CMAKE_COMMAND} -E remove_directory ${copy_dest}
+ COMMAND ${CMAKE_COMMAND} -E remove ${copy_dest}
COMMENT "Removing ${name} from LLDB.framework")
add_dependencies(lldb-framework-cleanup
${name}-cleanup)
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
