bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land.
I like this. I have no opinion on having `-i/-b` versus `--mode/-m` to indicate which mode crashlog.py should use, though I think that using an enum makes it easier to add new modes down the line so I'm okay with this implementation (note: I can't think of any other kinds of modes I would add later). LGTM, @JDevlieghere any objections? ================ Comment at: lldb/examples/python/crashlog.py:47 - print_lock = threading.RLock() ---------------- nit: no need to remove this line. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141658/new/ https://reviews.llvm.org/D141658 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
