clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Gotcha, makes sense now. Thanks for the extra info. We do need to make sure the
m_symbol_file values match and return an empty TypeSP if they don't. Once that
is done, this is good to go.
================
Comment at: lldb/include/lldb/Symbol/SymbolFile.h:527
+ lldb::TypeSP CopyType(const lldb::TypeSP &other_type) override {
+ lldb::TypeSP type_sp (new Type(*other_type));
+ m_type_list.Insert(type_sp);
----------------
We have to check if other_type has the same symbol file and return nothing if
it doesn't match.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142052/new/
https://reviews.llvm.org/D142052
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
