asahay added inline comments.
================
Comment at: lldb/test/Shell/helper/build.py:29
default='host',
- choices=['32', '64', 'host'],
help='Specify the architecture to target.')
----------------
Michael137 wrote:
> Why was this needed?
>
> Other than that, LGTM
IIUC, //~/lldb/test/Shell/helper/toolchain.py// supplies LLDB's bitness (and
not the target architecture) as //arch// to
//~/lldb/test/Shell/helper/build.py// unconditionally. However, we may require
the target architecture too to customize the compile and link commands (we did
in our downstream project, at least). Perhaps, we'd like both, LLDB's bitness
and the target architecture to be supplied via separate options but I thought
that lifting the restriction in question might've sufficed until we'd
provisioned support for the same. Let me know if we'd like it handled (or, not
dealt with at all) in this change itself, though, please.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140839/new/
https://reviews.llvm.org/D140839
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
