JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

Looks reasonable to me.

@lawrence_danna do you happen to remember why you wrote:

  exe = os.path.join(os.path.realpath(os.path.dirname(exe)), os.readlink(exe))

instead of

  exe = os.path.realpath(exe)

which seems like it should be equivalent? Aand you're doing a `realpath` call 
anyway...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141042/new/

https://reviews.llvm.org/D141042

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to